In reviewing worldlogsnorkellingchampion I wonder about the introduction of the TextWriter directly and LogParameter method. It seems to me a might-bit heavy-handed to be deciding the formatting of the log parameters being emitted, and dictating that they will be written to a TextWriter directly. This has an odor for me because:
- The formatting is set-in-stone
- There's some casting-about to get to scale and precision, which looks like an impedance-mismatch
-
We're forcing the logger to make the effort to write to TextWriter even if we might subsequently discard the output